[gui/design] Update Line & Freeform tools to not overcount tiles #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Aug 23, 2024
There was a problem hiding this comment.
Could you add a line in the "Fixes" section of the "Future" version in changelog.txt?
https://github.com/DFHack/scripts/blob/master/changelog.txt#L40
Otherwise, looks good! Thanks!
Also, please feel free to add your name to https://github.com/DFHack/dfhack/blob/develop/docs/about/Authors.rst
|
@myk002 Updated changelog. Created Authors PR: DFHack/dfhack#4869 |
myk002
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: DFHack/dfhack#3927
Validations:
Simple line now counts properly:
Symmetrical double-line now counts property:
Counts properly even w/incresed line thickness:
Single point curved line still counts properly:
Dual point curved line still counts properly:
Freeform line which is open now counts properly:
Freeform line which is closed now counts properly:
Even the xtra thikk, freeform lines now count properly:
